TRAC: 54484 - REST API: Return empty object instead of empty array for meta field #10889
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @vishal.kakadiya@rtcamp.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
|
||
| // Use stdClass so that JSON result is {} and not []. | ||
| if ( empty( $response ) ) { | ||
| return new stdClass(); |
There was a problem hiding this comment.
Alternatively:
| return new stdClass(); | |
| return (object) array(); |
This is the approach taken in src/wp-includes/abilities/class-wp-settings-abilities.php.
| * @return array|stdClass Array containing the meta values keyed by name, | ||
| * or stdClass if empty to ensure JSON object encoding. |
There was a problem hiding this comment.
| * @return array|stdClass Array containing the meta values keyed by name, | |
| * or stdClass if empty to ensure JSON object encoding. | |
| * @return array|object Array containing the meta values keyed by name, | |
| * or an empty object if to ensure JSON object encoding. |
2 participants
Ticket: https://core.trac.wordpress.org/ticket/54484